Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gas price calculation in CommunityPool contract #1705

Conversation

yavrsky
Copy link
Contributor

@yavrsky yavrsky commented Sep 19, 2024

During a recent investigation, it was found that block.basefee in the call returns 0, so it was decided to return tx.gasprice back and set it ourselves during the call to getRecommendedRechargeAmount. Also, in the _balanceIsSufficient method, tx.gasprice was replaced with block.basefee, which avoids manipulation of the gasprice during the call to rechargeUserWallet.

@yavrsky yavrsky closed this Oct 30, 2024
@yavrsky yavrsky deleted the 1027-getrecommendedrechargeamount-call-sometimes-returns-0 branch October 30, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant